New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tockloader: init at v1.4.0 #80829
tockloader: init at v1.4.0 #80829
Conversation
e1dd613
to
00ca3bc
Compare
How is the python-packages.nix top-level file sorted? |
it's not. Some additions grouped similar packages. a lot just did lexigraphical sorting. Right now it's just a "best try" |
Updated to disable python2 support, which was failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.
If tests are not available, then please use pythonImportsCheck
to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors.
----------------------------------------------------------------------
Ran 0 tests in 0.000s
I tried importing the TockLoader class, but couldn't properly adress it. I tried https://github.com/tock/tockloader/blob/master/tockloader/tockloader.py#L28 So for now I settled for the package import, which isn't very helpful. |
The package has no test suite and their CI job just tries to call |
That's.... concerning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this only meant to be use as an application? (E.g $ tockloader ....
)? If so, then it probably doesn't belong in python-modules
. See https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#buildpythonapplication-function
Ah yeah, that is probably the case. Thanks for the link. |
Ok, ready for review again. |
meta = with lib; { | ||
homepage = "https://github.com/tock/tockloader"; | ||
license = licenses.mit; | ||
description = "Tool for programming Tock onto hardware boards."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add yourself as a maintainer :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair, done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as far as --help
is concerned.
Motivation for this change
Tockloader describes itself as a "Tool for programming Tock onto hardware boards."
Personally I'm trying to get OpenSK (https://github.com/google/OpenSK) running on a Nordic nRF52840 MDK and the deploy process requires among other things tockloader.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)